refactor(installer): unify Vite+ setup into the global cli by liangmiQwQ · Pull Request #2611 · voidzero-dev/vite-plus

liangmiQwQ · 2026-09-05T07:36:31Z

Bash installer, PowerShell installer, vp-setup.exe, and vp upgrade now share the target binary's setup code. Moving installation logic into vp reduces duplication and platform differences, and lets each new version own its setup changes.

Installers download and verify the target, then let it install itself. A completion marker makes setup run on first launch and retry after failure. This also lets old vp upgrade reach the new setup through its existing vp env setup --refresh call, while keeping its download and activation flow.

Setup always creates vpx and vpr shims, uses system-first mode when users decline Node.js management, and reports failures back to the installers.

Installers probe for self-setup support and fall back to the legacy implementations for older targets. Keeping those legacy installers accounts for the net line increase, even though the new scripts are much smaller (reduce more than 2500 line).

Here, “new” and “old” refer to the installers and vp implementations after and before this change. This PR does not change setup-vp. 🟢 indicates a supported compatibility path; it does not imply that every historical version combination has been tested.

Scenario	Compatibility mechanism	Status
Upgrade an existing Vite+ installation using the new install script	The target binary installs itself, reuses the existing installation directory, and updates dependencies, `current`, and shims.	🟢
New install script → new `vp`	Probes for `vite-plus-self-setup-v1`, then hands installation over to the target binary.	🟢
New install script → old `vp`	Falls back to the retained legacy installer when the target does not support self-setup.	🟢
Old install script → new `vp`	The old script’s existing `env setup` invocation triggers the new binary’s first-start setup.	🟢
Old `vp upgrade` → new `vp`	The existing `env setup --refresh` call triggers in-place setup, preserving configuration and rollback history.	🟢
New `vp upgrade` → new `vp`, including same-version reinstalls	Clears the target’s completion marker, then triggers setup through the refresh call.	🟢
Rollback between versions 0.3.0 and later	Switches `current` and refreshes the environment through `env setup --refresh`.	🟢
`setup-vp` calling the new install script	Preserves directory variables returned by source/dot-source. Calls that do not declare directory awareness default to `~/.vite-plus`, keeping PATH consistent.	🟢
New `vp-setup.exe` → versions 0.3.0 and later	Hands installation over to the target binary when self-setup is supported; otherwise uses the Rust legacy installer.	🟢

🤖 Generated with Codex

netlify · 2026-09-05T07:36:38Z

✅ Deploy Preview for viteplus-preview canceled.

Name	Link
🔨 Latest commit	`8f1ee79`
🔍 Latest deploy log	https://app.netlify.com/projects/viteplus-preview/deploys/6a9d7c515d62f10008c2d414

liangmiQwQ · 2026-09-05T11:10:55Z

@codex review

chatgpt-codex-connector · 2026-09-05T11:11:11Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-09-05T11:50:25.849290Z	`4179d59`	Manual request

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 072785da3c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

liangmiQwQ · 2026-09-05T11:21:24Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 95c99baec5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

liangmiQwQ · 2026-09-05T11:32:28Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 013777b09d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

liangmiQwQ · 2026-09-05T11:44:01Z

@codex review

chatgpt-codex-connector · 2026-09-05T11:50:24Z

Codex Review: Didn't find any major issues. 🎉

Reviewed commit: 4179d59433

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

…rrors

liangmiQwQ · 2026-09-05T13:50:59Z

One left problem might be #1338 (comment), but it is not a big deal, this PR already copies the original behavior, this could be reconsidered after this merged.

fengmk2 · 2026-09-05T15:25:58Z

@liangmiQwQ Can you describe whether all the various compatibility issues after this change have been taken into account? For example, whether users who have upgraded from the old version using Vite+ via the new install.sh are compatible. Or whether the new and old versions of setup-vp are compatible with install.sh, etc.

liangmiQwQ · 2026-09-06T01:29:06Z

CI failing is fixed in #2616

liangmiQwQ · 2026-09-06T01:40:44Z

@liangmiQwQ Can you describe whether all the various compatibility issues after this change have been taken into account? For example, whether users who have upgraded from the old version using Vite+ via the new install.sh are compatible. Or whether the new and old versions of setup-vp are compatible with install.sh, etc.

@fengmk2 I have intentionally considered compatibility issues during this refactor. Detailed compatibility table is included in the PR description.

github-actions · 2026-09-06T15:08:05Z

Registry bridge build (`8f1ee79`)

Warning

This build is from the fork liangmiQwQ/vite-plus and has not been reviewed.
Installing it runs that code on your machine. Build log

This commit build is published to the registry bridge, which serves these as ordinary npm versions (every other package proxies to npmjs):

Package	Version
`vite-plus`	`0.0.0-commit.8f1ee79aa9f7e49e26fa55eca1cc03c2d8088b2c`
`@voidzero-dev/vite-plus-core`	`0.0.0-commit.8f1ee79aa9f7e49e26fa55eca1cc03c2d8088b2c`

Install the Vite+ CLI built from this commit, then migrate a project:

# macOS / Linux
curl -fsSL https://raw.githubusercontent.com/liangmiQwQ/vite-plus/8f1ee79aa9f7e49e26fa55eca1cc03c2d8088b2c/packages/cli/install.sh | VP_PR_VERSION=2611 bash

# Windows (PowerShell)
$env:VP_PR_VERSION="2611"; irm https://raw.githubusercontent.com/liangmiQwQ/vite-plus/8f1ee79aa9f7e49e26fa55eca1cc03c2d8088b2c/packages/cli/install.ps1 | iex

Or download the standalone Windows installer built from this commit:

Architecture	Installer
x64	`vp-setup-x86_64-pc-windows-msvc.exe`
Arm64	`vp-setup-aarch64-pc-windows-msvc.exe`

GitHub requires you to sign in and downloads each installer as a ZIP artifact. Extract vp-setup.exe, then run it against this preview build:

.\vp-setup.exe --version "0.0.0-commit.8f1ee79aa9f7e49e26fa55eca1cc03c2d8088b2c" --registry "https://registry-bridge.viteplus.dev/"

After installing, upgrade the current project's vite-plus to this test build with:

vp migrate

Or point your package manager at the bridge registry https://registry-bridge.viteplus.dev/:

Package manager	Registry config
npm / pnpm / Bun	`.npmrc`: `registry=https://registry-bridge.viteplus.dev/`
Yarn (v2+)	`.yarnrc.yml`: `npmRegistryServer: "https://registry-bridge.viteplus.dev/"`

Then pin the build (vite aliases to vite-plus-core; pnpm can use a catalog, npm an overrides entry):

{
  "devDependencies": {
    "vite-plus": "0.0.0-commit.8f1ee79aa9f7e49e26fa55eca1cc03c2d8088b2c",
    "vite": "npm:@voidzero-dev/vite-plus-core@0.0.0-commit.8f1ee79aa9f7e49e26fa55eca1cc03c2d8088b2c"
  }
}

liangmiQwQ added 3 commits September 5, 2026 12:29

refactor(installer): separate bootstrap from legacy setup

4fe5a90

feat(cli): set up unmarked binaries on first launch

561b56a

refactor(installer): delegate installation to binary self-setup

8bb2130

liangmiQwQ added test: e2e Auto run e2e tests test: install-e2e run vite install e2e test test: create-e2e Run `vp create` e2e tests test: sfw labels Sep 5, 2026

liangmiQwQ added 5 commits September 5, 2026 15:48

fix(installer): preserve bootstrap compatibility and failure status

64f7a24

test(installer): preserve setup state in upgrade fixtures

33309ef

fix(cli): honor NO_COLOR in shared output prefixes

818deea

fix(installer): propagate shell failures and defer color cleanup

510120e

fix(installer): return resolved directories to the calling shell

072785d

chatgpt-codex-connector Bot reviewed Sep 5, 2026

View reviewed changes

Comment thread crates/vp_global_cli/src/self_setup.rs Outdated

Comment thread crates/vp_global_cli/src/self_setup.rs Outdated

Comment thread packages/cli/install.ps1

Comment thread crates/vp_global_cli/src/self_setup.rs

fix(installer): preserve interactive shell handoff behavior

95c99ba

chatgpt-codex-connector Bot reviewed Sep 5, 2026

View reviewed changes

Comment thread crates/vp_global_cli/src/self_setup.rs

Comment thread crates/vp_global_cli/src/commands/upgrade/mod.rs

Comment thread crates/vp_global_cli/src/self_setup.rs

fix(installer): use bridge registry for preview self-setup

013777b

chatgpt-codex-connector Bot reviewed Sep 5, 2026

View reviewed changes

Comment thread crates/vp_global_cli/src/self_setup.rs Outdated

Comment thread crates/vp_global_cli/src/self_setup.rs

Comment thread crates/vp_installer/src/main.rs

fix(installer): retain terminal for interactive self-setup

4179d59

fix(installer): confirm entrypoint replacement and tolerate profile e…

8dccf47

…rrors

liangmiQwQ marked this pull request as ready for review September 5, 2026 13:48

liangmiQwQ requested a review from fengmk2 September 5, 2026 13:52

fix(cli): use colorful theme for self-setup confirmations

d001646

liangmiQwQ changed the title ~~refactor(installer): delegate installation to target binary self-setup~~ refactor(installer): unify Vite+ setup into the global CLI Sep 5, 2026

liangmiQwQ changed the title ~~refactor(installer): unify Vite+ setup into the global CLI~~ refactor(installer): unify Vite+ setup into the global cli Sep 5, 2026

fengmk2 added the preview-build Publish this PR's commits to the registry bridge as preview builds label Sep 5, 2026

kazupon mentioned this pull request Sep 5, 2026

fix: more safer Vite+ global install and vp upgrade #1338

Merged

Merge branch 'main' into liang/codex/refactor-installer

be0e698

fengmk2 self-assigned this Sep 6, 2026

fengmk2 added preview-build Publish this PR's commits to the registry bridge as preview builds and removed preview-build Publish this PR's commits to the registry bridge as preview builds labels Sep 6, 2026

liangmiQwQ added 4 commits September 6, 2026 10:12

Merge branch 'main' into liang/codex/refactor-installer

21642b7

chore(ci): retry flaky Windows Socket Firewall test

73d6136

chore(ci): trigger fresh CI validation

1d1849a

Merge branch 'main' into liang/codex/refactor-installer

2ff63a9

liangmiQwQ added preview-build Publish this PR's commits to the registry bridge as preview builds and removed preview-build Publish this PR's commits to the registry bridge as preview builds labels Sep 6, 2026

liangmiQwQ added 3 commits September 6, 2026 21:14

fix(ci): skip self-setup for packaged planner verification

dab8ba0

fix(ci): verify certless commands bypass self-setup

0d2cb88

Merge branch 'main' into liang/codex/refactor-installer

8f1ee79

liangmiQwQ added preview-build Publish this PR's commits to the registry bridge as preview builds and removed preview-build Publish this PR's commits to the registry bridge as preview builds labels Sep 6, 2026

Uh oh!

Conversation

liangmiQwQ commented Sep 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify Bot commented Sep 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for viteplus-preview canceled.

Uh oh!

liangmiQwQ commented Sep 5, 2026

Uh oh!

chatgpt-codex-connector Bot commented Sep 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

liangmiQwQ commented Sep 5, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

liangmiQwQ commented Sep 5, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

liangmiQwQ commented Sep 5, 2026

Uh oh!

chatgpt-codex-connector Bot commented Sep 5, 2026

Uh oh!

liangmiQwQ commented Sep 5, 2026

Uh oh!

fengmk2 commented Sep 5, 2026

Uh oh!

liangmiQwQ commented Sep 6, 2026

Uh oh!

liangmiQwQ commented Sep 6, 2026

Uh oh!

github-actions Bot commented Sep 6, 2026

Registry bridge build (8f1ee79)

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

liangmiQwQ commented Sep 5, 2026 •

edited

Loading

netlify Bot commented Sep 5, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Sep 5, 2026 •

edited

Loading

Registry bridge build (`8f1ee79`)